RE: PerfSocket.cpp and TOS
> >Date: Thu, 21 Nov 2002 13:34:47 -0800
> >From: John Webster <jwebster --at-- es.net>
> >To: dast --at-- nlanr.net
> >Subject: PerfSocket.cpp and TOS
> >
> >Hello,
> >
> >Shouldn't the char in line 520 of PerfSocket.cpp be an int?
> >
> > char tos = gSettings->GetTOS();
> >
> >That's what the GetTOS() function is returning.
Yeah in theory that would be the case, but the TOS field is only 8 bits
wide so we used the char. I am not sure what setsockopt requires. In
windows it wants a int, so we would have alignment errors. I looked at
the generic UNIX sockets requirements they do not care as long as you
pass the correct length so it shouldn't matter unless you run windows
where it probably does not matter either the SDK could be wrong. I
may, depending on results from testing, make a change to be nicer to
windows for 1.6.4, which is due soon, hopefully. On a side note you have
to apply some registry hacks to get TOS settings under Win2k and above.
> >Also, in 1.6.3 the ability to set window size seems to have vanished.
> >Works fine in 1.6.2.
setsock_tcp_windowsize( mSock, gSettings->GetTCPWindowSize() );
got removed from just above line 520 that you mentioned above, I apologize
it had to of been my fault though I am not entirely sure when I did this.
Yeah this is a big reason why 1.6.4 will be coming soon.
Kevin
--
Mitch Kutzko | mitch --at-- dast.nlanr.net | mitch --at-- ncsa.uiuc.edu | 217-333-1199
http://hobbes.ncsa.uiuc.edu/