Re: Usermode per-flow selection of congestion control algorithm
On 3/16/06, Angelo P. Castellani <angelo.castellani+iperf --at-- gmail.com> wrote:
> here is the patch
>
> 2006/3/15, Angelo P. Castellani
> <angelo.castellani+iperf --at-- gmail.com>:
> > Starting with linux kernel 2.6.15, users can choose which congestion
> control algorithm should be used for a TCP connection.
> >
> > Here is a patch that adds an iperf parameter to use that feature.
> >
> > Regards,
> > Angelo P. Castellani
> >
>
Angelo,
After having a bit more of a look at the code I would suggest the following:
- Don't use #define TCP_CONGESTION as then you have to set/unset. I
would suggest you don't need this as person will only use -A when
needed. You do read the default congestion control though based on
this. I would suggest that this is not needed as then the code will
work on any OS directly without #define. If a user wants to know which
congestion control they are using they can look at the sysctl.
- put some text in the usage help in src/Locale.c to explain the option
- Don't use if !isUDP to test if TCP as that breaks on other protocols
e.g. DCCP/SCTP. Instead test mProtocol == kTCP
Looks really good though in general and I will certainly use if
comparing TCP variants.
Ian
--
Ian McDonald
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
Department of Computer Science
University of Waikato
New Zealand